Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: Move duplicated dummyTeam into a constants file #603

Closed
kkangs0226 opened this issue Feb 17, 2021 · 2 comments · Fixed by #609
Closed

Tests: Move duplicated dummyTeam into a constants file #603

kkangs0226 opened this issue Feb 17, 2021 · 2 comments · Fixed by #609
Assignees
@kkangs0226
Labels
aspect-CodeQuality p.Low low value, can be delayed indefinitely

Comments

@kkangs0226
Copy link
Contributor

kkangs0226 commented Feb 17, 2021 •
edited

Mock Team is currently defined in multiple specs files as dummyTeam.
It will be good to move this definition to the data.constants.ts file to avoid code duplication.

Please refer to PR #592
@kkangs0226 kkangs0226 added aspect-CodeQuality p.Low low value, can be delayed indefinitely labels Feb 17, 2021
@dingyuchen
Copy link
Contributor

Most uses of dummyTeam does not require any special properties of the Team object. Maybe it will sufficient to simply expose TEAM_3 and TEAM_4?
For dummyIssues that does not need access to the teamAssigned attribute, it suffices to pass null into the issue factory. Perhaps it will be good to refactor some of these uses to use null instead as well.

@kkangs0226
Copy link
Contributor Author

I agree that we can use TEAM_3 or TEAM_4 for the dummy teams! Let's keep to these two constants.

@kkangs0226 kkangs0226 assigned kkangs0226 and unassigned kkangs0226 Feb 21, 2021
@kkangs0226 kkangs0226 mentioned this issue Feb 21, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kkangs0226 kkangs0226

Labels
aspect-CodeQuality p.Low low value, can be delayed indefinitely
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tests: Move duplicated dummyTeam into a constants file kkangs0226/CATcher
2 participants
@dingyuchen @kkangs0226