Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'Download Logs' button visible before login for downloading authentication logs #652

Closed
kkangs0226 opened this issue Mar 15, 2021 · 4 comments · Fixed by #730
Closed
Assignees
Labels
category.Enhancement an enhancement to an existing feature

Comments

@kkangs0226
Copy link
Contributor

Users are only able to download logs after they are logged in, which means we will not be able to view authentication logs when they cannot log in in the first place.

We could make 'Download logs' button visible before login so users can download authentication logs even if they are unable to log in.

@kkangs0226 kkangs0226 added the category.Enhancement an enhancement to an existing feature label Mar 15, 2021
@damithc
Copy link
Contributor

damithc commented Mar 15, 2021

Note that 'download logs' is not a major feature and not a part of the main workflow. So, we don't want to show it too prominently on too many places either.

@kkangs0226
Copy link
Contributor Author

Perhaps we can make it less conspicuous before log in, or just resize the button in general across the entire app? The button looks like this at the moment:

image

If we do not want it to be too conspicuous, I think we can consider relocating the button to somewhere other than the top bar. What do the other developers think?

@dingyuchen
Copy link
Contributor

I think for a short term measure, we can have the download-log button to only be the icon, with the name appear on tooltip upon hovering to reduce the visual footprint.
This might work since we don't have that many buttons on the headerbar yet, however it is also possible that students will think that the icon is not interactive.

In the future, we can consider having a kebab menu or hamburger menu to house all the extraneous functions if we decide to add more. This would let us keep the UI clean.

@AudreyFelicio
Copy link
Contributor

@kkangs0226 @damithc @dingyuchen
Hi, is this issue still available?
Can I work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category.Enhancement an enhancement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants