Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SessionFixConfirmationComponent: Fix bug in permission prompt #676

Merged
merged 5 commits into from
Apr 9, 2021
Merged

SessionFixConfirmationComponent: Fix bug in permission prompt #676

merged 5 commits into from
Apr 9, 2021

Conversation

kkangs0226
Copy link
Contributor

@kkangs0226 kkangs0226 commented Apr 3, 2021 •
edited by anubh-v

Summary

Fixes #674

Changes made

  • Fixed method to return false when 'No thanks' option is chosen
  • Fixed bug such that repository creation is prevented

Commit Message:

When CATcher requests permission to create a repo for bug reporting
phase, selecting "No thanks" does not prevent repo creation.

The app proceeds as if "Yes" was selected.

Let's fix this bug by ensuring that SessionFixConfirmationComponent
returns `false` (and not `undefined`) when "No thanks" is selected.

@kkangs0226 kkangs0226 requested a review from a team April 3, 2021 00:10
ptvrajsk
ptvrajsk approved these changes Apr 4, 2021
View reviewed changes
Copy link
Contributor

@ptvrajsk ptvrajsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this 👍

@anubh-v anubh-v changed the title Clicking 'No thanks' in permission prompt does not prevent repo creation SessionFixConfirmationComponent: Fix bug in permission prompt Apr 9, 2021
@anubh-v anubh-v merged commit f005ee5 into CATcher-org:master Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anubh-v anubh-v anubh-v approved these changes

@ptvrajsk ptvrajsk ptvrajsk approved these changes

Assignees
No one assigned
Labels
s.ToMerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking 'No thanks' in permission prompt does not prevent repo creation
3 participants
@kkangs0226 @anubh-v @ptvrajsk