Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn Mores aren't opening in "mobile view" or "reduced user interface" #247

Open
JessicaFrank opened this issue Apr 6, 2023 · 10 comments · May be fixed by #261 or #262
Open

Learn Mores aren't opening in "mobile view" or "reduced user interface" #247

JessicaFrank opened this issue Apr 6, 2023 · 10 comments · May be fixed by #261 or #262
Assignees
Labels

Comments

@JessicaFrank
Copy link
Contributor

Learn mores are appearing as clickable links in the mobile view or reduced user interface version of the A2J Viewer, but the links aren't actually clickable.

End users aren't able to access to the content in the Learn More in any way.

image

No errors in the console

Pop ups are clickable and working as expected.

@JessicaFrank
Copy link
Contributor Author

@tobiasnteireho
Copy link
Contributor

confirmed to fail in Safari 16.3, Chrome 111, and Firefox 111 on Ventura 13.2. Only firefox displays a console error: Error: Promised response from onMessage listener went out of scope [init.js:79:27](moz-extension://baf7f2fa-6c58-224a-aa8b-68278b7c0c3a/background/init.js)

@tobiasnteireho
Copy link
Contributor

related to #248

@tobiasnteireho
Copy link
Contributor

tobiasnteireho commented Apr 6, 2023

html differs significantly between mobile view and desktop. This is for a learn-more in this gi
Desktop view:

<button class="learn-more" aria-label="What does a learn more look like in mobile view?" target="_blank" on:click="../fireLearnMoreModal()" on:keydown="keydownFireClickHandler(scope.event, ../fireLearnMoreModal)" aui-action="help">What does a learn more look like in mobile view?</button>

mobile view:

<a class="learn-more" aria-label="Why does this matter?">Why does this matter?</a>

The mobile view is missing code to create the Modal

@JessicaFrank
Copy link
Contributor Author

Learn Mores in reduced interface work on LHI's instance of the viewer (7.2.3, 2022-02-10 version of the viewer)

@JessicaFrank
Copy link
Contributor Author

The learn more and the pop up open @tobiasnteireho in the viewerdev version, but there's still something wrong with it. At the end of the learn more (and on every page of the interview, even if no learn more associated with that page) aui-action="help" displays in that space as a hyperlink.

image

On the page with a learn more, it just appears at the end of the learn more link (see image above).

On the pages with out learn mores, it is a standalone clickable link. When I click it, the learn more modal opens, but it's blank.
image

image

@tobiasnteireho
Copy link
Contributor

@JessicaFrank Updated and ready for retesting.

@JessicaFrank
Copy link
Contributor Author

@tobiasnteireho tested viewerdev on my phone and desktop. Confirmed learn mores are working as expected in reduced interface and mobile version. I tested on two GIs. Can you please test in Safari? Once that's done, I'm good locking this for a code push.

@tobiasnteireho tobiasnteireho linked a pull request Dec 22, 2023 that will close this issue
@tobiasnteireho tobiasnteireho linked a pull request Feb 9, 2024 that will close this issue
@tobiasnteireho
Copy link
Contributor

works in mobile and desktop safari

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants