[BUG] Conditional options break when changing a mode value

[superblaubeere27]

LiquidBounce Branch

Nextgen

LiquidBounce Build/Version

latest

Operating System

Linux

Minecraft Version

1.20.4

Describe the bug

I mean what the hell is even that?

Steps to reproduce

1. Change a mode that has it's own values
2. ???
3. Profit

Client Log

-

Screenshots

[1zun4]

It is a Svelte bug. Will be fixed with #1442

[leumasme]

Code in Question:

LiquidBounce/src-theme/src/routes/clickgui/clickgui/settings/ChoiceSetting.svelte

Lines 47 to 53 in 32ccda6

	{#if reference.choices[reference.active].value.length > 0}
	<div class="settings" transition:fade|local={{duration: 200, easing: sineInOut}}>
	{#each reference.choices[reference.active].value as s}
	<GenericSetting reference={s} write={write} />
	{/each}
	</div>
	{/if}

Probably fixable using a keyed each block: https://svelte.dev/examples/keyed-each-blocks

[1zun4]

Code in Question:

LiquidBounce/src-theme/src/routes/clickgui/clickgui/settings/ChoiceSetting.svelte

Lines 47 to 53 in 32ccda6

	{#if reference.choices[reference.active].value.length > 0}
	<div class="settings" transition:fade|local={{duration: 200, easing: sineInOut}}>
	{#each reference.choices[reference.active].value as s}
	<GenericSetting reference={s} write={write} />
	{/each}
	</div>
	{/if}

Probably fixable using a keyed each block: https://svelte.dev/examples/keyed-each-blocks

Thank you, but either I am doing something wrong or it does not work.
75b658e

[leumasme]

0028576.mp4

Works fine with keyed each block in ChoiceSetting.svelte
Note that the dev setup for the frontend currently does not work at all ever since #1557 (because the code uses the current URL as the websocket URL, which results in the wrong port when using the dev server), so you might have not actually been viewing your modified UI when testing.

[1zun4]

Fixed with the new theme.