Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Documents #19

Closed

Conversation

ItsAdityaKSingh
Copy link
Contributor

@ItsAdityaKSingh ItsAdityaKSingh commented Dec 26, 2021

Minor updates with easy merging and no feature changes.

Partially fixes issue #15

  • Added punctuation marks and fixed typos in documentation.

Fixes issue #20

  • Added channel stable instead of master to avoid runtime errors while installing the app.

@ItsAdityaKSingh
Copy link
Contributor Author

@techno-disaster You may merge this PR.

@techno-disaster techno-disaster mentioned this pull request Dec 26, 2021
@techno-disaster
Copy link
Member

IMHO we don't really need this atm, so closing. (no one really sees commas and full stops afaik). As for the flutter master or stable changes, that would require changing stuff in a lot of places including the ci and ccextractor.org which can be done sometime later in a seperate MR specifically for this.

@ItsAdityaKSingh
Copy link
Contributor Author

But during installation of this particular repo, the installation guide causes error in master. I guess it would be well off for others if it's changed. Also I wanted to start contributing to this repository and these documentary changes were a good start I had :(

@techno-disaster
Copy link
Member

h

But during installation of this particular repo, the installation guide causes error in master. I guess it would be well off for others if it's changed. Also I wanted to start contributing to this repository and these documentary changes were a good start I had :(

readme and ci switched to stable. f49a9ab

@ItsAdityaKSingh ItsAdityaKSingh deleted the doc-changes branch December 31, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants