Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Files and Documents #14

Closed
wants to merge 8 commits into from

Conversation

ItsAdityaKSingh
Copy link
Contributor

@ItsAdityaKSingh ItsAdityaKSingh commented Dec 23, 2021

Minor updates with easy merging and no feature changes.

Fixes issue #15

  • Updated pubspeck.lock and dependencies with the introduction of Flutter 2.8!
  • Added punctuation marks and fixed typos in documentation.
  • Added Podfile and other iOS files generated while running in the iOS environment.

@ItsAdityaKSingh
Copy link
Contributor Author

@techno-disaster, my local tests are passing; any idea why CI tests fail? I guess it's because CI tests use flutter 2.8 to build and test. Could you look into it?

@techno-disaster
Copy link
Member

The ci uses flutter master (which should probably be changed) , didn't you use flutter to 2.8 in this PR as well?

@ItsAdityaKSingh
Copy link
Contributor Author

Yeah, I did, that's the reason for updates in pubspeck.lock file.

@techno-disaster
Copy link
Member

Yeah, I did, that's the reason for updates in pubspeck.lock file.

does flutter test work for you locally? if not you should probably fix that.

@ItsAdityaKSingh
Copy link
Contributor Author

Sure I am going to give it a look, seems like I'm having some errors running it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants