Conversation
oh and yeah, it moves the installation stuff out of the scripts folder. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, just a comment.
docs/Developer-guidlines.md
Outdated
@@ -20,6 +20,15 @@ If you're looking to code, there are a few ways to help: | |||
* Reviewing [Pull Requests](https://github.com/CCI-MOC/ims/pulls) | |||
* Discussions on open github issues. | |||
|
|||
|
|||
## Settin up a dev environment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot a 'g' here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I'm talking like a G.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed.
@apoorvemohan @mihirborkar can either of you review this? This is pretty straightforward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks fine
* This removes the scripts that installed ceph, hil, bmi and all related packages.
We have the scripts to setup ceph and HIL on a different repo, and we have the ansible playbook here to deploy bmi. All that obviates the need for the scripts to setup a whole development environment.
Fixes #159