Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silently fails with unit cell containing single atom #16

Open
dch0ph opened this issue Feb 10, 2023 · 1 comment
Open

Silently fails with unit cell containing single atom #16

dch0ph opened this issue Feb 10, 2023 · 1 comment

Comments

@dch0ph
Copy link

dch0ph commented Feb 10, 2023

OK, a rather artificial test case:
H_CSAalong_c.zip

Nothing happens on load. Behaves fine when second atom added.

But any silent failure indicates some fragility / undocumented assumptions about user input.
@jkshenton
Copy link
Member

Good find -- thanks!

Seems the issue is actually to do with getting the camera in the right place -- it wasn't doing that correctly when the target was zero. I have an initial fix working which I'll push through after some more checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkshenton @dch0ph