Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully_sampled_recon_three_chains fails #31

Closed
KrisThielemans opened this issue May 23, 2019 · 6 comments · Fixed by #32
Closed

fully_sampled_recon_three_chains fails #31

KrisThielemans opened this issue May 23, 2019 · 6 comments · Fixed by #32
Assignees
Milestone

Comments

@KrisThielemans
Copy link
Member

Same problem as SyneRBI/SIRF#293

@KrisThielemans
Copy link
Member Author

Fixing the ExtractGadget is going to be hard. I suggest we comment it out and do instead

import numpy as np
import sirf.Utiltities
...
real_image_array=np.abs(complex_image_data.as_array())
sirf.Utilities.show_3D_array(real_image_array)

@evgueni-ovtchinnikov
Copy link
Contributor

Found bugs in ExtractGadget, created Gadgetron issue #743.

I feel the workaround applied was not a good idea - we no longer have three chains, so the name of the demo is confusing, and the single chain demo is still affected by one of the bugs (the first one in #743) anyway.

@KrisThielemans
Copy link
Member Author

@evgueni-ovtchinnikov is this still relevant? We need to either fix this, or move the broken notebook(s) to a subfolder with a name broken or similar.

@KrisThielemans KrisThielemans modified the milestones: v2.0, v3.1 Jun 11, 2021
@evgueni-ovtchinnikov
Copy link
Contributor

the notebook is actually ok except that it now should be called fully_sampled_recon_two_chains

@KrisThielemans
Copy link
Member Author

great. Please "git mv" and adjust a README (if any), and close this issue then.

@KrisThielemans
Copy link
Member Author

I've checked that it runs. I'm not sure about the naming, and it's fairly obsolete as a notebook anyway, so I'll just close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants