Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/Python/MR/acquisition_data.py #166

Closed
DANAJK opened this issue May 6, 2018 · 4 comments
Closed

examples/Python/MR/acquisition_data.py #166

DANAJK opened this issue May 6, 2018 · 4 comments
Assignees
Milestone

Comments

@DANAJK
Copy link
Contributor

DANAJK commented May 6, 2018

Incorrect script name in the Usage comment.

Also, where is the default for the range set, and why the choice of (254, 258)?

@KrisThielemans
Copy link
Member

@ckolbPTB, can you comment?

@KrisThielemans KrisThielemans added this to the v1.1 milestone May 9, 2018
@evgueni-ovtchinnikov
Copy link
Contributor

to show the boundary between repetitions - say, for the range (250,254) all data would be zeros except encoding - not very illuminative
docstrings corrected

@DANAJK
Copy link
Contributor Author

DANAJK commented May 10, 2018

This range sets the variable 'where' which then affects a number of print statements but not any numerical output?
At first sight the docstring is confusing - to me it implies the range of phase encode lines (readouts) will be restricted which would result in junk images.

@evgueni-ovtchinnikov
Copy link
Contributor

Yes, you are right, no data is affected.
To remind you, the docstring says:
-r , --range= range of readouts to examine as string '(a,b)'
If you find 'readouts to examine' not clear enough, please suggest a better wording (I was after a concise one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants