Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully_sampled_recon_three_chains fails #293

Closed
KrisThielemans opened this issue Jan 10, 2019 · 10 comments · Fixed by #1010
Closed

fully_sampled_recon_three_chains fails #293

KrisThielemans opened this issue Jan 10, 2019 · 10 comments · Fixed by #1010
Assignees
Labels
Gadgetron Caused by a Gadgetron bug
Milestone

Comments

@KrisThielemans
Copy link
Member

At present, image_array has shape [0,0,0]. complex_image_data seems alright though (its shape after as_array is [2,256,256]).

I haven't checked the corresponding SIRF demo.

@evgueni-ovtchinnikov
Copy link
Contributor

fully_sampled_recon_three_chains.ipynb works fine on my laptop

@KrisThielemans KrisThielemans transferred this issue from SyneRBI/SIRF-Exercises Jan 12, 2019
@KrisThielemans KrisThielemans changed the title fully_sampled_recon_three_chains.ipynb fails (with SIRF master) fully_sampled_recon_three_chains fails on Archlinux (with SIRF master) Jan 12, 2019
@KrisThielemans
Copy link
Member Author

@evgueni-ovtchinnikov I've moved this issue here. I have checked that on my VM both the notebook and actual demo work fine. However, on an archlinux install both fail. This could be a gadgetron server issue but Gadgetron's unit-tests and integration tests work. I have no clue what to do about it. would it help if I see if I can give you access to the archlinux system?

@evgueni-ovtchinnikov
Copy link
Contributor

@KrisThielemans: access to archlinux would certainly help - how else can i investigate what goes wrong there :)
what is archlinux anyway?

@KrisThielemans
Copy link
Member Author

we've seen problems with the other Gadgetron demos returning only 1 image as opposed to both repetitions. Seems to be related to reading the ISMRMRD file.

@KrisThielemans
Copy link
Member Author

@evgueni-ovtchinnikov I've tried rebuilding with our version of HDF5 as opposed to the system one. Same problem unfortunately.

@KrisThielemans KrisThielemans added this to the v2.1 milestone Mar 12, 2019
@KrisThielemans KrisThielemans changed the title fully_sampled_recon_three_chains fails on Archlinux (with SIRF master) fully_sampled_recon_three_chains fails May 23, 2019
@KrisThielemans
Copy link
Member Author

we have this same problem now on the new VM. Everything is fine until here https://github.com/CCPPETMR/SIRF/blob/ea4a56f9f07ae5a17d74887fbca002dc69313b5c/examples/Python/MR/Gadgetron/fully_sampled_recon_three_chains.py#L109

c=complex_image_data.as_array()
c.shape

returns (2, 256, 256), and a display of the numpy.abs(c) looks fine.

However, the extracted array is not https://github.com/CCPPETMR/SIRF/blob/ea4a56f9f07ae5a17d74887fbca002dc69313b5c/examples/Python/MR/Gadgetron/fully_sampled_recon_three_chains.py#L114-L118


In [44]: real_image_data.number()
Out[44]: 0

In [45]: real_image_data.as_array().shape
Out[45]: (0, 0, 0)

@KrisThielemans
Copy link
Member Author

This could be a Gadgetron change/bug I guess.

@evgueni-ovtchinnikov
Copy link
Contributor

evgueni-ovtchinnikov commented Sep 6, 2019

caused by bugs in new ExtractGadget, Gadgetron issue gadgetron/gadgetron#743 created

@evgueni-ovtchinnikov evgueni-ovtchinnikov added the Gadgetron Caused by a Gadgetron bug label Sep 6, 2019
@evgueni-ovtchinnikov evgueni-ovtchinnikov modified the milestones: v2.1, v2.2 Sep 6, 2019
@KrisThielemans
Copy link
Member Author

They fixed one bug in master quite a while ago. We need to retest this with current Gadgetron master

@KrisThielemans KrisThielemans modified the milestones: v3.0, v3.1 Feb 11, 2021
@paskino
Copy link
Contributor

paskino commented Feb 11, 2021

If you want to try to build Gadgetron master there's a SuperBuild branch and also a related draft PR SyneRBI/SIRF-SuperBuild#438

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gadgetron Caused by a Gadgetron bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants