although it was correct, osx gave lots of warnings for -Wlogical-op-parentheses #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2019 11:37
…arentheses replace `if (a || b && c)` with `if (a || (b && c))` even though the two are the same.
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 50.05% 50.05%
=======================================
Files 2 2
Lines 1720 1720
=======================================
Hits 861 861
Misses 859 859Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
=======================================
Coverage 50.05% 50.05%
=======================================
Files 2 2
Lines 1720 1720
=======================================
Hits 861 861
Misses 859 859Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
if (a || b && c)withif (a || (b && c))even though the two are the same.