Fix tag detection for git clone/update scripts #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking that the object type is "tag" only works for annotated tags. If case someone decides to make a lightweight tag (or does it by mistake), it will now correctly be handled.
| @@ -3,7 +3,7 @@ | |||
| cd "@CMAKE_INSTALL_PREFIX@" | |||
| "@GIT_EXECUTABLE@" clone --no-checkout --depth 1 -b @BRANCH@ @GIT_URL@ "@GIT_TARGET@" | |||
There was a problem hiding this comment.
I thought the problem would be here with -b option since that would not respect light weight tags.
There was a problem hiding this comment.
-b works with lightweight tags as far as I can tell
There was a problem hiding this comment.
On certain git versions it does not (you should see reporting on this if you do a google search). I would suggest, we take out the -b option, and just checkout the right branch / tag afterwards.
There was a problem hiding this comment.
It looks like --depth cannot be used if we get rid of -b, else git only gets HEAD and the ref we need might not be fetched at all.
|
In that case, merging this one. We will deal with this issue later then. |
aashish24
added a commit
that referenced
this pull request
Jun 26, 2015
Fix tag detection for git clone/update scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amends #993
Checking that the object type is "tag" only works for annotated tags. If case someone decides to make a lightweight tag (or does it by mistake), it will now correctly be handled.
Interestingly, this only seems to be used by 'vistrails', so I don't think it will fix build warnings like:
which I think just leak through from ExternalProject but are not actual errors(?)