Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up global-organization-override #8016

Open
3 tasks
stephenkao opened this issue Jan 19, 2023 · 0 comments
Open
3 tasks

Clean up global-organization-override #8016

stephenkao opened this issue Jan 19, 2023 · 0 comments
Labels
engineering Work to be completed by an engineer experience Team label to flag issues owned by the Experience Team Low Priority

Comments

@stephenkao
Copy link

stephenkao commented Jan 19, 2023

Problem statement

We maintain a global-membership-state value in LocalStorage for the current user's Organization and a global-organization-override value for impersonated Organization. However, since both values are updated upon impersonation, it may be redundant to maintain both values instead of just using the global-membership-state.

At the moment, it doesn't seem to help us to maintain two separate values, especially since we use memberType to determine UI visibility across the site.

What you need to know

Acceptance criteria

  • Investigate whether or not global-organization-override can be removed safely
    • If so, remove global-organization-override logic
    • If not, document why not on this ticket and communicate out to engineering team
@stephenkao stephenkao added engineering Work to be completed by an engineer experience Team label to flag issues owned by the Experience Team needs-refinement Tickets that need refinement from the team labels Jan 19, 2023
@chris-kuryak chris-kuryak removed the needs-refinement Tickets that need refinement from the team label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
engineering Work to be completed by an engineer experience Team label to flag issues owned by the Experience Team Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants