Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cross-database delete transactions #180

Merged
merged 2 commits into from
Jul 8, 2022

Conversation

dk-lockdown
Copy link
Collaborator

ref: https://github.com/cectc/dbpack/issues/

Ⅰ. Describe what this PR did

If the delete operation needs to be executed on multiple database shards, the distributed transaction should be coordinated to ensure the atomicity of the delete operation.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

check integration test result

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #180 (06412d3) into dev (e74302a) will decrease coverage by 0.38%.
The diff coverage is 3.44%.

❗ Current head 06412d3 differs from pull request most recent head 45885e9. Consider uploading reports for the commit 45885e9 to get more accurate results

@@            Coverage Diff             @@
##              dev     #180      +/-   ##
==========================================
- Coverage   46.75%   46.36%   -0.39%     
==========================================
  Files          76       77       +1     
  Lines        8643     8713      +70     
==========================================
- Hits         4041     4040       -1     
- Misses       4216     4286      +70     
- Partials      386      387       +1     
Impacted Files Coverage Δ
pkg/executor/sharding.go 0.00% <0.00%> (ø)
pkg/filter/dt/filter_mysql.go 1.61% <ø> (+0.14%) ⬆️
pkg/filter/dt/filter_mysql_prepare.go 0.00% <0.00%> (ø)
pkg/filter/dt/filter_mysql_query.go 0.00% <0.00%> (ø)
pkg/misc/hint.go 0.00% <0.00%> (ø)
pkg/plan/insert.go 50.00% <0.00%> (ø)
pkg/plan/query.go 40.64% <0.00%> (ø)
pkg/plan/result.go 75.34% <0.00%> (-2.35%) ⬇️
pkg/plan/update.go 15.78% <0.00%> (ø)
pkg/plan/delete.go 7.27% <2.27%> (-3.84%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e74302a...45885e9. Read the comment docs.

@dk-lockdown dk-lockdown merged commit 90f9d42 into CECTC:dev Jul 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants