Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add python examples #58

Merged
merged 1 commit into from May 17, 2022
Merged

feat: add python examples #58

merged 1 commit into from May 17, 2022

Conversation

zhu733756
Copy link
Contributor

Signed-off-by: zhu733756 zhuhan@cestc.cn

ref: #31

Ⅰ. Describe what this PR did

add python examples

Ⅱ. Does this pull request fix one issue?

#31

Ⅲ. Why don't you add test cases (unit test/integration test)?

No need

Ⅳ. Describe how to verify it

See README

Ⅴ. Special notes for reviews

None.

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@zhu733756
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request May 15, 2022
@zhu733756 zhu733756 changed the title add python examples [WIP]add python examples May 15, 2022
samples/python/config2.yaml Show resolved Hide resolved
samples/python/config2.yaml Outdated Show resolved Hide resolved
samples/python/config3.yaml Outdated Show resolved Hide resolved
samples/python/config3.yaml Outdated Show resolved Hide resolved
@zhu733756
Copy link
Contributor Author

OK. This feature still needs further impoved and under WIP

@zhu733756 zhu733756 changed the title [WIP]add python examples feat: add python examples May 16, 2022
@zhu733756
Copy link
Contributor Author

Done @dk-lockdown Pls take a look.

Copy link
Collaborator

@dk-lockdown dk-lockdown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

Codecov Report

Merging #58 (ffdd1a3) into dev (041a9e1) will decrease coverage by 3.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev      #58      +/-   ##
==========================================
- Coverage   34.22%   30.96%   -3.26%     
==========================================
  Files          42       46       +4     
  Lines        4947     5651     +704     
==========================================
+ Hits         1693     1750      +57     
- Misses       3085     3726     +641     
- Partials      169      175       +6     
Impacted Files Coverage Δ
pkg/filter/dt/transaction.go 0.00% <0.00%> (ø)
pkg/filter/dt/filter_http.go 3.44% <0.00%> (ø)
pkg/filter/dt/filter_mysql.go 17.24% <0.00%> (ø)
pkg/filter/dt/executor.go 4.53% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 041a9e1...ffdd1a3. Read the comment docs.

@zackzhangkai
Copy link
Contributor

lgtm

Copy link
Collaborator

@bohehe bohehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: zhu733756 <zhuhan@cestc.cn>
@dk-lockdown dk-lockdown merged commit e9ad844 into CECTC:dev May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants