Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kernel.split_particle returns by reference in Numba #160

Open
ilhamv opened this issue Feb 14, 2024 · 0 comments
Open

kernel.split_particle returns by reference in Numba #160

ilhamv opened this issue Feb 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ilhamv
Copy link
Collaborator

ilhamv commented Feb 14, 2024

The use of kernel.split_particle is treated as a call by reference in Numba. The current use of the function is always followed by kernel.add_particle, which passes by value to particle banks. However, if we (naively) use it to create intermediate particles for some operations (like in the embedded sensitivity method), this would cause issues. What is interesting is that the function returns by value in Python.

@jpmorgan98 jpmorgan98 added the bug Something isn't working label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants