Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation issue #170

Closed
lewisfish opened this issue Mar 21, 2024 · 2 comments
Closed

Installation issue #170

lewisfish opened this issue Mar 21, 2024 · 2 comments
Assignees
@jpmorgan98

Comments

@lewisfish
Copy link

lewisfish commented Mar 21, 2024 •
edited

Hi MCDC team,
I'm one of the reviewers working on reviewing your JOSS submission openjournals/joss-reviews#6415.

Currently following the instructions in the README and the readthedocs webpage fails to install the package.
Currently on creating a Conda env, cloning the repo and running bash install.sh gives:

CommandNotFoundError: No command 'conda mpi4py'.

I see from PR #162 and #165 it has been fixed but not merged into the main branch.
Can this be merged into the main branch so I can tick off the installation item on my review list?
@jpmorgan98 jpmorgan98 mentioned this issue Mar 21, 2024
Merged
@jpmorgan98
Copy link
Collaborator

I opened a PR, when the CI finishes I'll have some one merge it. Thanks!

@jpmorgan98 jpmorgan98 self-assigned this Mar 21, 2024
@jpmorgan98
Copy link
Collaborator

Everything is merged thanks @lewisfish!!!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpmorgan98 jpmorgan98

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lewisfish @jpmorgan98