Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashes in environmental value names are not compatible with some shells #235

Closed
nazywam opened this issue Nov 21, 2023 · 1 comment · Fixed by #240
Closed

Dashes in environmental value names are not compatible with some shells #235

nazywam opened this issue Nov 21, 2023 · 1 comment · Fixed by #240

Comments

@nazywam
Copy link
Member

nazywam commented Nov 21, 2023

Some of karton services use the dash (-) character within section names.
This works fine for .ini files but can cause problems when configured using environmental values. [1]

Some of the solutions we could fix that:

  • base all services on bash instead of sh - it seems that bash handles them correctly
  • add a short pre-processor when loading values from env so that user can e.g. use a __ instead of a -

[1] kubernetes/kubernetes#16863

@nazywam
Copy link
Member Author

nazywam commented Jan 15, 2024

I think this issue can be closed after adding a small warning in the https://karton-core.readthedocs.io/en/latest/service_configuration.html docs section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant