Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a performance counter for unique ngram reads #198

Closed
msm-code opened this issue Dec 17, 2022 · 0 comments · Fixed by #199
Closed

Add a performance counter for unique ngram reads #198

msm-code opened this issue Dec 17, 2022 · 0 comments · Fixed by #199

Comments

@msm-code
Copy link
Contributor

Looks like we don't track the most important metric - how many unique ngrams did we read. Benchmarking done in #197 has shown, that reading a ngram for a second time is almost as fast as reading it from RAM, but the first read is very slow (especially on HDD).

We should add a performance counter for that and return that in a response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant