Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new command: index with taints #31

Closed
msm-code opened this issue Apr 11, 2020 · 5 comments
Closed

Add a new command: index with taints #31

msm-code opened this issue Apr 11, 2020 · 5 comments
Labels
level:medium This issue is of average difficulty priority:medium Priority: medium status:up for grabs This issue is a good candidate for PR type:feature New feature
Milestone

Comments

@msm-code
Copy link
Contributor

Right now, if I want to have a new dataset tagged as xyz, I need to run two separate commands:

index "/xxx" with [gram3]
dataset [id of the newly created dataset] taint "xyz";

This is pretty complex, especially since indexing can take a long time and dataset ID is not known upfront. Instead, I'd like to have a combined command (syntax subject to change):

index "/xxx" with [gram3] with taints ["xyz"]
@msm-code msm-code added level:medium This issue is of average difficulty priority:medium Priority: medium status:up for grabs This issue is a good candidate for PR type:feature New feature labels Apr 11, 2020
@msm-code msm-code changed the title Add new command: index with taints Add a new command: index with taints Apr 11, 2020
@ITAYC0HEN
Copy link
Contributor

Why "taint" was chosen for the emaning of "label" or "tag"?
Anyways, good idea.

What about

index "/xxx" with [gram3] as ["xyz"]

@msm-code
Copy link
Contributor Author

Not sure 🤔. That's how they were called during the design. I think that I sometimes refer to them as tag in mquery, which may cause even more confusion.

Probably because the original goal was to mark some datasets as special, so they won't get merged into other, clean ones.

I don't think this feature is used outside by anyone outside of cert.pl and mquery internally, so it's not too late change it, if you think it's worth it.

@ITAYC0HEN
Copy link
Contributor

Absolutely up to you :) I don't think it is a describing name, but maybe it's a popular term I've never heard in relation to tagging and labeling.

Screenshot_20200412-082429

@msm-code
Copy link
Contributor Author

msm-code commented Apr 12, 2020

The name was stolen from https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/

Taints are the opposite – they allow a node to repel a set of pods.
(...) One or more taints are applied to a node; this marks that the node should not accept any pods that do not tolerate the taints.

But yeah, tag is probably make easily understood in this context 🤔

@msm-code
Copy link
Contributor Author

msm-code commented Dec 7, 2021

Closing since this feature is already implemented (with the original name and original syntax)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
level:medium This issue is of average difficulty priority:medium Priority: medium status:up for grabs This issue is a good candidate for PR type:feature New feature
Projects
None yet
Development

No branches or pull requests

2 participants