Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ursadb is thread safe #32

Closed
msm-code opened this issue Apr 11, 2020 · 2 comments · Fixed by #94
Closed

Ensure ursadb is thread safe #32

msm-code opened this issue Apr 11, 2020 · 2 comments · Fixed by #94
Assignees
@chivay
Labels
level:hard This issue may be challenging priority:medium Priority: medium type:feature New feature
Milestone
v1.5.0

Comments

@msm-code
Copy link
Contributor

msm-code commented Apr 11, 2020 •
edited

Right now there are some edge cases when ursadb can have problems, when there are a lot of threads writing and reading data at the same time. We should ensure that we're hanling all these cases correctly.
@msm-code msm-code added level:hard This issue may be challenging priority:medium Priority: medium type:feature New feature labels Apr 11, 2020
@chivay chivay self-assigned this Apr 11, 2020
@msm-code msm-code added this to the v1.4.0 milestone Apr 15, 2020
@msm-code
Copy link
Contributor Author

Ok, so actually there's no need to be distributed. We only need to make sure that we're thread safe (i.e. we only care about a single machine)

@msm-code msm-code changed the title Make distributed ursadb more user friendly Ensure ursadb is thread safe Apr 22, 2020
@msm-code
Copy link
Contributor Author

msm-code commented May 2, 2020

Improved with #94. This issue is not actionable as is, so I'll just create new issues for other threading-related crashes (if found).

@msm-code msm-code closed this as completed May 2, 2020
@msm-code msm-code linked a pull request May 2, 2020 that will close this issue
Fix thread safety for tasks (no dangerous shared copies) #94
Merged
@msm-code msm-code mentioned this issue Dec 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chivay chivay

Labels
level:hard This issue may be challenging priority:medium Priority: medium type:feature New feature
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

Fix thread safety for tasks (no dangerous shared copies) CERT-Polska/ursadb
2 participants
@msm-code @chivay