Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SBP: Give indexes to you pallets #41

Closed
NachoPal opened this issue May 23, 2022 · 4 comments
Closed

SBP: Give indexes to you pallets #41

NachoPal opened this issue May 23, 2022 · 4 comments

Comments

@NachoPal
Copy link

It is a good practice to give indexes to your runtime pallets.

More info here: https://substrate.stackexchange.com/questions/1163/whats-the-logic-behind-polkadots-choice-in-pallet-indexing

@tehsunnliu
Copy link
Member

Hello Nacho,
Thank you for your feedback. We will resolve all the issues that you have created asap.

@swowk
Copy link
Member

swowk commented May 26, 2022

cc @ytqaljn

@ytqaljn
Copy link
Member

ytqaljn commented Jun 1, 2022

Thank you for your comments. Our team will discuss about the index range of the substrate pallet we quote, the index range of our own unique pallet, and the appropriate size of our reserved space

@ytqaljn
Copy link
Member

ytqaljn commented Jun 15, 2022

We have added indexes for all runtime pallets:
style: runtime pallets indexing (#57)

@ytqaljn ytqaljn closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants