Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons disappears after touching the cell #121

Closed
muchabartek opened this issue Mar 28, 2014 · 10 comments
Closed

Buttons disappears after touching the cell #121

muchabartek opened this issue Mar 28, 2014 · 10 comments

Comments

@muchabartek
Copy link

Hi, I imported the latest fixes and noticed an issue.
When I click on a cell when buttons are hidden, when I try to swipe, blank area shows up, buttons are missing.
Does anyone have idea what's wrong?

@CEWendel
Copy link
Owner

These are the utility buttons that are not showing up?

@muchabartek
Copy link
Author

Yes, on both - left and right - sides

@CEWendel
Copy link
Owner

Can you attach a screenshot or the behavior you are seeing?

Sent from my iPhone

On Mar 28, 2014, at 4:02 PM, Bartosz Mucha notifications@github.com wrote:

Yes, on both - left and right - sides


Reply to this email directly or view it on GitHub.

@muchabartek
Copy link
Author

Actually I tracked down source of this issue - buttons are hiding inside setHighlited: and setHighlited:animated: methods. Looks like cell is not reverted to unhighligted state and this is the issue.
Can you suggest some workaround?

@CEWendel
Copy link
Owner

I still do not see the behavior you are describing, please attach a screenshot to show what is going wrong. Thanks!

@muchabartek
Copy link
Author

Sure, below are before and after images:

ios simulator screen shot 29 mar 2014 21 16 54
ios simulator screen shot 29 mar 2014 21 17 02

@CEWendel
Copy link
Owner

And what are the steps to reproduce this? Sorry for all the questions I just can't seem to reproduce this on my build.

@CEWendel CEWendel reopened this Mar 29, 2014
@muchabartek
Copy link
Author

When I touch cell in center state I navigate to separate screen, after going back buttons are missing. I'm sure that navigating to other screen is not relevant and it would work the same way even if I was still on the same screen.
I use a custom storyboard prototype cell with selection style set to none.

After some testing, when I comment out hiding utility buttons in both setHighlited methods it's fine, but I know there is a purpose for those lines of code, so that's not a solution.

Hope this helps, please let me know what are your findings.

@CEWendel
Copy link
Owner

Ok, will work on fixing this. Thanks!

@CEWendel
Copy link
Owner

Well actually with the new implementation of selection, there is no purpose of the setHighlighted: code. So I just took that out. Should work now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants