Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust library to allow for the use of custom views built in interface builder #39

Closed
wants to merge 8 commits into from
Closed

Adjust library to allow for the use of custom views built in interface builder #39

wants to merge 8 commits into from

Conversation

MattCBowman
Copy link
Contributor

This change does a few things:

  1. Breaks apart the classes to make it easier to navigate
  2. Update the cocoa pod spec to use the new location for the library files
  3. Allows the user to set the table view, left buttons and right buttons after initialization
  4. Allow the use of custom views built in interface builder

@CEWendel
Copy link
Owner

Awesome! I will pull this down and test it out tomorrow. Thanks a bunch, Matt.

harlanhaskins and others added 4 commits November 28, 2013 22:49
@harlanhaskins
Added a check in gestureRecognizer:shouldRecognizeSimultaneouslyWithG…
7c13ea5 
…estureRecognizer: for if the tableView's scroller is scrolling up or down. This became a real problem with a long list of cells, because the sliding would get tripped while trying to scroll the cell. This way, the intent of the user is more accurately represented.
@harlanhaskins
Added better, much more reliable method for grabbing the right view (…
1b31fca 
…instead of iterating through superviews, just pick the view attached to the gestureRecognizer.)
@CEWendel
Cleaning up a bit and removing unnecessary code
f776241
@CEWendel
Merge branch 'master' of github.com:CEWendel/SWTableViewCell
08e15c7
@MattCBowman
Copy link
Contributor Author

@CEWendel - Thank you for all your work leading up to this! 👍

@heumn
Copy link

heumn commented Dec 2, 2013

Great work Matt!

@mhupman
Copy link

mhupman commented Dec 2, 2013

👍

@Adrian2112
Copy link
Contributor

👍
Just missing some docs to let you know how to use it with nibs

@CEWendel
Copy link
Owner

CEWendel commented Dec 2, 2013

Yea an example would be great, I can't seem to figure out how to get custom views working with interface builder with these changes.

@MattCBowman
Copy link
Contributor Author

Hey @CEWendel - I'll put together some how-to docs tonight

Matt Bowman added 2 commits December 2, 2013 17:11
Merge pull request #1 from Adrian2112/master
fe5cd25 
hide the swipe menu when all the elements have a clear background
Update documentation, add custom cell to sample project to show how i…
aa65917 
…t works
@MattCBowman
Copy link
Contributor Author

Hey @CEWendel - I've updated the sample project to include code to render custom cells, and I have updated the readme.md to include an example on how to use it with custom cells.

@MattCBowman MattCBowman mentioned this pull request Dec 3, 2013
Closed
Matt Bowman added 2 commits December 4, 2013 10:19
Incorporate new changes between my fork and the current master branch
9fe59b2
Merge branch 'github_master'
c47866b 
Conflicts:
	SWTableViewCell/PodFiles/SWTableViewCell.h
	SWTableViewCell/SWTableViewCell.m
	SWTableViewCell/ViewController.m
@MattCBowman
Copy link
Contributor Author

@CEWendel - In case you were concerned about losing the most recent changes made to the repo, I've just updated my PR to include them.

@CEWendel
Copy link
Owner

CEWendel commented Dec 5, 2013

Ok cool thanks Matt gonna check this out today. Sorry it's been a busy week (last week of classes).

@CEWendel
Copy link
Owner

CEWendel commented Dec 6, 2013

Cool so everything looks good except one thing, which I am working on fixing now.
When scrolling right in this branch, there is no spring effect in the scroll view for the cell, but there still is when you scroll left.

Once those are fixed we can merge this in, it's looking great.

Thanks again.

@MattCBowman
Copy link
Contributor Author

Hey @CEWendel - Was the bounce something you added? I looked through the code and couldn't find anything that would explicitly add springiness to the TableViewCell. If you did add that behavior, and could point me in the right direction, I'll take care of fixing it. Thanks!

@CEWendel
Copy link
Owner

CEWendel commented Dec 6, 2013

Cool. This is all merged in now after just tweaking a couple things, I added back in the gesture recognizer check to see if the containing scroll view is currently being scrolled and took out an unneeded setContentOffset call that was getting rid of the bounce effect.

Thanks Matt! Gonna give you a shout out on the README right now.

@CEWendel CEWendel closed this Dec 6, 2013
@MattCBowman
Copy link
Contributor Author

Thanks, @CEWendel! We just located the problem that you mentioned in your comment. We were minutes away from updating the PR 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MattCBowman @CEWendel @heumn @mhupman @Adrian2112 @harlanhaskins