Drop iOS 7 support not to crush in iOS 14 #430
+1
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaizume
commented
Sep 11, 2020
| @@ -91,12 +89,7 @@ - (void)initializer | |||
| // Add the cell scroll view to the cell | |||
| UIView *contentViewParent = self; | |||
| UIView *clipViewParent = self.cellScrollView; | |||
| if (![NSStringFromClass([[self.subviews objectAtIndex:0] class]) isEqualToString:kTableViewCellContentView]) | |||
There was a problem hiding this comment.
AT here, index out of range because of [self.subviews objectAtIndex:0] call towards self.subviews which is void.
There was a problem hiding this comment.
If you remove this part of the code, the cell is not clickable, swipe doesn't work, but you can build the app. This is not a solution, for now.
No crash
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My app suddenly crushed when I built it with Xcode 12.0 beta 6 and run in iOS 14 beta 8.
I found that
self.subviewsreturns 0 during cell initialization for iOS 14.The code was for supporting iOS 7 but it's reasonable to drop it.
After this change, the crush seems no longer appear.