Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update our MathJax to 2.4 at least #2356

Closed
lrineau opened this issue Aug 21, 2017 · 7 comments
Closed

Update our MathJax to 2.4 at least #2356

lrineau opened this issue Aug 21, 2017 · 7 comments
Assignees
Milestone

Comments

@lrineau
Copy link
Member

lrineau commented Aug 21, 2017

Currently, https://doc.cgal.org/MathJax/ serves MathJax version 2.1. Google Chrome reports an unsafe use of fonts from about:blank, and blocks something. That is the issue mathjax/MathJax#256, fixed in 2.4 (June 2014).

@afabri
Copy link
Member

afabri commented Feb 14, 2018

@lrineau Can you delegate that to @maxGimeno ??

@maxGimeno
Copy link
Contributor

I don't have the rights to install nor upgrade anything on the server, so I don't think he can.

@lrineau
Copy link
Member Author

lrineau commented Feb 14, 2018

Anyway, you will do tests locally one your machine, and then let me know which files must be copied on the doc.cgal.org server.

@maxGimeno
Copy link
Contributor

I don't know what I am supposed to test and as it seems the only thing to do is fetch and checkout form doc.cgal.org/Mathjax I don't know what you want me to do.

@lrineau
Copy link
Member Author

lrineau commented Mar 17, 2018

I no longer see the warning in Chrome console. But anyway the changes from MathJax 2.1 to 2.7 are pretty long, and there are performance and usability improvements. I think we choose upgrade, after checking that there is no regression.

@maxGimeno
Copy link
Contributor

I checked the result of doc_with_postprocessing on Triangulated Surface Mesh Segmentation and saw no regression with MathJax 2.7.2.

@lrineau
Copy link
Member Author

lrineau commented Apr 9, 2018

I have updated to MathJax 2.7.4, at https://doc.cgal.org/MathJax/. All seems well.

@lrineau lrineau closed this as completed Apr 9, 2018
@lrineau lrineau added this to the 4.12-beta2 milestone Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants