Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad Interval_nt forward declaration in 5.4.x-branch #6705

Closed
mglisse opened this issue Jun 23, 2022 · 0 comments · Fixed by #6707
Closed

Bad Interval_nt forward declaration in 5.4.x-branch #6705

mglisse opened this issue Jun 23, 2022 · 0 comments · Fixed by #6707
Assignees
Milestone

Comments

@mglisse
Copy link
Member

mglisse commented Jun 23, 2022

template <bool> class Interval_nt;
namespace CGAL {

Interval_nt is forward declared, but in the wrong namespace. This was fixed in #6120. Without backporting the whole PR, I wonder if we could backport just this tiny piece to 5.4.x-branch, moving the declaration a few lines below.

#ifndef NOBUG
#include <CGAL/NT_converter.h>
#endif
#include <CGAL/Epeck_d.h>

int main(){
  boost::multiprecision::mpq_rational q = 42;
  CGAL::NT_converter<boost::multiprecision::mpq_rational,CGAL::Interval_nt<>> c;
  c(q);
}

fails to compile with 5.4 and would be fixed by such a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants