Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPA via SUSPENDED task state. Question. #603

Open
timurhai opened this issue May 11, 2024 · 2 comments
Open

PPA via SUSPENDED task state. Question. #603

timurhai opened this issue May 11, 2024 · 2 comments
Assignees
Labels
Milestone

Comments

@timurhai
Copy link
Member

New task state appeared in 3.4.0 - SUSPENDED. Such task will not run.
This is needed to control tasks running from outside, manual tasks dependence can be solved within this state.
Later you can just skip task, but SKIPPED task considered as DONE. Job with skipped tasks considered as DONE.
Job with SUSPENDED is not done, it is SUSPENDED.

I think that if PPA will be implemented via SUSPENDED tasks, it will be more clean.
PPA job will make all not sequential tasks as SUSPENDED.
Approve can be via continue suspended action.

What do you think?

@timurhai timurhai added this to the 3.4.0 milestone May 11, 2024
@timurhai timurhai self-assigned this May 11, 2024
@sebastianelsner
Copy link
Contributor

Sounds fair to me. @ultra-sonic what do you think?

@ultra-sonic
Copy link

how is SUSPENDED different than PPA? can you please elaborate on the added benefit? i'm afraid that this may add confusion on the artists end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants