Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

City,CountryCode broken #28

Closed
fcaza opened this issue Oct 23, 2019 · 4 comments · Fixed by #34
Closed

City,CountryCode broken #28

fcaza opened this issue Oct 23, 2019 · 4 comments · Fixed by #34

Comments

@fcaza
Copy link

fcaza commented Oct 23, 2019 •
edited
Loading

City,CountryCode is now broken
try:
weather.setCity('Roma,IT');

Actually, it didn't worked as well in 4.0.0
It's because of encodeURIComponent in setCity?
@velsa
Copy link

velsa commented Dec 12, 2019

Looks like a real issue.
E.g. if you have a city name with a space in it, space is translated into %2520 instead of %20

@CICCIOSGAMINO
Copy link
Owner

I'm working on ... i'll be solved in the v5.0.0 coming soon !!

@knoguchi
Copy link

knoguchi commented Apr 8, 2020

The string is encoded twice. That's why encoded to %20 and encoded again to %2520

@naofireblade naofireblade mentioned this issue May 1, 2020
Merged
@naofireblade
Copy link

I created a PR to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed double encoding of city name naofireblade/openweather-apis
5 participants
@knoguchi @velsa @fcaza @CICCIOSGAMINO @naofireblade