This repository has been archived by the owner on Aug 13, 2020. It is now read-only.
Access control component #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-rich
suggested changes
Jun 21, 2017
| @@ -5,6 +5,9 @@ on [Keep a CHANGELOG](http://keepachangelog.com/). This project adheres to | |||
|
|
|||
| ## [Unreleased] | |||
|
|
|||
| ### Changed | |||
| - Improved logging for annotation scanning | |||
There was a problem hiding this comment.
you didn't add the change for this commit.
| @@ -42,14 +42,15 @@ public void initialise() { | |||
| * | |||
| * @param envelope - the envelope to be audited. | |||
There was a problem hiding this comment.
additional param for javadoc? - or just remove if inheriting from interface.
| } | ||
|
|
||
| @Test(expected = IllegalStateException.class) | ||
| public void shouldComponentIsNotSetThrowException() throws Exception { |
There was a problem hiding this comment.
shouldThrowExceptionIfComponentNotSet ?
| @@ -19,16 +19,18 @@ | |||
|
|
|||
| @Override | |||
| public InterceptorContext process(final InterceptorContext interceptorContext, final InterceptorChain interceptorChain) { | |||
| recordAudit(interceptorContext.inputEnvelope()); | |||
| final String component = (String) interceptorContext.getInputParameter("component") | |||
There was a problem hiding this comment.
could we add getComponent() on InterceptorContext?
Presumably it is used elsewhere already so makes sense to have it in one place and also not expose the "component" value?
purple52
force-pushed
the
access-control-component
branch
2 times, most recently
from
73e1422
to
529d4c5
Compare
This is a workaround to allow audit to know which component within a service a message is coming from, until we have a better way of discovering the context, service, and componet names.
purple52
force-pushed
the
access-control-component
branch
from
529d4c5
to
ebb7f05
Compare
matt-rich
approved these changes
Jun 21, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.