Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPR #602

Closed
QuietlyWhisper opened this issue Nov 19, 2023 · 3 comments · Fixed by #743
Closed

CPR #602

QuietlyWhisper opened this issue Nov 19, 2023 · 3 comments · Fixed by #743
Assignees
Labels
Issue: Feature Request This issue is a feature request Low Priority Minor issues not very important

Comments

@QuietlyWhisper
Copy link
Contributor

QuietlyWhisper commented Nov 19, 2023

Should start an interaction that when each repeated relatively quick doafter is completed, forces the targeted player to take a breath as if they were not in crit state

An early attempt to make this was in space-wizards/space-station-14#19437
If this is completed, the finished product should be pushed upstream

This may conflict with @Jezithyr wound refactor however

@DrSmugleaf DrSmugleaf added the Issue: Feature Request This issue is a feature request label Nov 22, 2023
@QuietlyWhisper QuietlyWhisper added the Low Priority Minor issues not very important label Nov 28, 2023
@Hmeister-fake
Copy link
Contributor

Delta-V has working CPR with a whole sprite for it. Maybe try to port it?

@QuietlyWhisper
Copy link
Contributor Author

Delta-V has working CPR with a whole sprite for it. Maybe try to port it?

I did try to port it, see the linked PR
It's not a great implementation because it isn't networked correctly + several bugs that were bandaid fixed

Unless they redid it again recently, CPR needs to be made from ground up according to @DrSmugleaf

@DrSmugleaf
Copy link
Contributor

I haven't seen Delta-V's implementation of CPR recently, but there's not much of a point to copying the one that was closed upstream since the implementation is short enough and the code structure has enough mistakes that makes it easier to re-implement ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Feature Request This issue is a feature request Low Priority Minor issues not very important
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants