Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Magazine Updates - Before First Playtest #936

Closed
5 tasks done
Aexxie opened this issue Jan 18, 2024 · 7 comments
Closed
5 tasks done

Magazine Updates - Before First Playtest #936

Aexxie opened this issue Jan 18, 2024 · 7 comments
Labels
help wanted Extra attention is needed Issue: Feature Request This issue is a feature request Medium Priority Issues that need to be done but may not be as important as higher issues No C# For things that don't need code

Comments

@Aexxie
Copy link
Contributor

Aexxie commented Jan 18, 2024

Description

As requested in Pull #935, I need someone to update several magazine capacities to their intended values. I also need a cartridge sprite for .44 bullets.

Checklist:

  • Update capacity of CMMagazineExtendedRifleM41A
  • Update capacity of CMMagazineRifleM4RA
  • Update capacity of CMMagazineRifleExtendedM4RA
  • Update capacity of CMMagazineExtendedCaselessM39
  • M44 Bullet (.44) - Will need to update line 28 in Resources/Prototypes/_CM14/Entities/Objects/Weapons/Guns/Ammunition/SpeedLoaders/revolver.yml accordingly.
@Aexxie Aexxie added help wanted Extra attention is needed No C# For things that don't need code Medium Priority Issues that need to be done but may not be as important as higher issues Issue: Feature Request This issue is a feature request labels Jan 18, 2024
@QuietlyWhisper
Copy link
Contributor

#16

@z9ctn4fn
Copy link
Contributor

Aye. I'll get on it.

@Aexxie
Copy link
Contributor Author

Aexxie commented Jan 21, 2024

#16

Right, thanks. I like having a specific list of things here so I can keep my own thoughts organized.

@DrSmugleaf
Copy link
Contributor

Fixed in #943 and b4b87bc

@Aexxie
Copy link
Contributor Author

Aexxie commented Jan 23, 2024

Fixed in #943 and b4b87bc

Awesome, thanks. I think the bullet itself still needs a prototype & sprite, I think I set up the tag so it should work when added. The cartridge type will still need to be changed in line 28 whenever it is added, because currently the speedloader is filled with standard .45s.

Edit: I may just add the prototype myself later, I don't know why I didn't do that to begin with.

@DrSmugleaf
Copy link
Contributor

Fixed in #943 and b4b87bc

Awesome, thanks. I think the bullet itself still needs a prototype & sprite, I think I set up the tag so it should work when added. The cartridge type will still need to be changed in line 28 whenever it is added, because currently the speedloader is filled with standard .45s.

Done in 0f60a8f, we don't have handfuls so we can't copy the sprites for those yet

@Aexxie
Copy link
Contributor Author

Aexxie commented Jan 23, 2024

Fixed in #943 and b4b87bc

Awesome, thanks. I think the bullet itself still needs a prototype & sprite, I think I set up the tag so it should work when added. The cartridge type will still need to be changed in line 28 whenever it is added, because currently the speedloader is filled with standard .45s.

Done in 0f60a8f, we don't have handfuls so we can't copy the sprites for those yet

On top of the game o7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed Issue: Feature Request This issue is a feature request Medium Priority Issues that need to be done but may not be as important as higher issues No C# For things that don't need code
Projects
None yet
Development

No branches or pull requests

4 participants