file_list file download button not downloading file

[cggit]

When uploading a PDF or Doc as a field type of "file_list" the resulting Download button from (Download/Remove) opens a media modal instead of downloading.

My fix is

CMB2/js/cmb2.js

Line 79 in 4bc8e98

.on( 'click', '.cmb-attach-list li, .cmb2-media-status .img-status img, .cmb2-media-status .file-status > span', cmb.handleFileClick )

to
.on( 'click', '.cmb2-media-status .img-status, .cmb2-media-status .file-status > span', cmb.handleFileClick )

and

CMB2/js/cmb2.js

Line 220 in 4bc8e98

var $el = $( this );

to
var $el = $( this ).hasClass('cmb2-media-item') ? $(this) : $(this).closest('.cmb2-media-item');

Can someone else confirm the problem and solution?

[jtsternberg]

Can you paste the before/after code or open a PR, or link to the related lines in github? The lines you are referencing do not make sense.

https://github.com/CMB2/CMB2/blob/trunk/js/cmb2.js#L77
https://github.com/CMB2/CMB2/blob/trunk/js/cmb2.js#L169

[jtsternberg]

I think it should be good now. Please test the trunk branch.

[cggit]

Great. That works too and is most slick! I updated my comment just so I know how to properly reference next time