Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Blocking bug with Python < 3.8 #12

Closed
LeDocteurDesBits opened this issue Mar 3, 2021 · 0 comments · Fixed by #13
Closed

[Bug] Blocking bug with Python < 3.8 #12

LeDocteurDesBits opened this issue Mar 3, 2021 · 0 comments · Fixed by #13
Assignees
Labels
bug Something isn't working

Comments

@LeDocteurDesBits
Copy link
Collaborator

There is a bug with old version of Python (< 3.8). The functions get_args and get_origin of the dataclass package are missing (because implemented in Python 3.8). The program won't start without these two functions.

I also noticed that some distributions always run Python 3.7 (Debian for instance). It means that the program wouldn't run on these distributions even if the user's packages are "up-to-date".

A solution can be to implement an alternative version of these two functions and check the Python's version. If it's below 3.8 then we could use our handmade functions, otherwise we would use the ones in the dataclass package. It hurts to develop such a ugly fix but I guess we don't have much solution if we want smersh-cli to run on almost every distribution.

@LeDocteurDesBits LeDocteurDesBits added the bug Something isn't working label Mar 3, 2021
@LeDocteurDesBits LeDocteurDesBits self-assigned this Mar 3, 2021
@LeDocteurDesBits LeDocteurDesBits linked a pull request Mar 3, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant