Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDCT-73 remove accepted and published status from filter #2342

Merged
merged 1 commit into from May 5, 2022

Conversation

gmrabian
Copy link
Contributor

@gmrabian gmrabian commented May 5, 2022

Description

Closes MDCT-73 - Removed 'accepted' and 'published' options from filter. These options show up elsewhere in the codebase though I left them for now since they seem to be used in other places and I don't want to disrupt existing work. Ex: selectors.js. If you think these or others can safely be removed, let me know and I'll expand the scope.

How to test

  • checkout branch
  • cd frontend/react
  • nvm use
  • npm run start

Navigate to localhost:3000, login, verify those two statuses don't appear in the status dropdown

Alternatively startup the dockerized version and verify it with all user types (other than state)

Dependencies

2 minutes of your time

Get it done

Crush the ticket and slam dunk it

Code authors checklist

  • I have performed a self-review of my code
  • I have added thorough tests. Testing Doc
  • Necessary analytics were added, or no new analytics were required
  • I have made corresponding changes to the documentation
  • I have assigned the PR to myself

Reviewers Checklist (Two different people)

  • I have done the deep review and verified the items in the above checklist are g2g
  • I have done the lgtm review

Assignee

  • I have closed the PR after the review and necessary changes (squashing preferred)

Copy link
Contributor

@bodnarbm bodnarbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Removes the user confusion and don't think it's worth stripping out the rest of it right now pre-rewrite.

Copy link
Contributor

@karla-vm karla-vm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified on the Dockerized version, everything's looking good!

@gmrabian gmrabian merged commit c4ba819 into master May 5, 2022
@gmrabian gmrabian deleted the remove-statuses-from-dropdown branch May 5, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants