Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript definition for StepList steps doesn't support substeps #845

Closed
pwolfert opened this issue Oct 12, 2020 · 9 comments
Closed

TypeScript definition for StepList steps doesn't support substeps #845

pwolfert opened this issue Oct 12, 2020 · 9 comments
Labels
Status: In JIRA Indicates that this item is also tracked in Jira Type: Fixed Indicates an unexpected problem or unintended behavior

Comments

@pwolfert
Copy link
Collaborator

We're trying to add steps with a steps property. It's supported in the UI but not the type definition.

@pwolfert pwolfert added the Type: Fixed Indicates an unexpected problem or unintended behavior label Oct 12, 2020
@bernardwang
Copy link
Collaborator

bernardwang commented Oct 12, 2020

@line47 I wonder if this would be a good opportunity to go ahead and move StepList into the HCgov DS. One way we could accomplish this is to add updated StepList definition files in the HCgov DS; we could do this right now without rereleasing the core. We'd still have to ensure its safe to start deprecating StepList in the core CMSDS and get a formal sign off from our POs, but that could happen later.

@pwolfert
Copy link
Collaborator Author

I was thinking the same thing—that it's just another reason to move it.

@line47
Copy link
Contributor

line47 commented Oct 12, 2020

@kathleenmeditz and I are in the middle of some Step List exploration work so hopefully after that we can have a clearer picture if deprecating at the core design system level makes sense. 👍

@bernardwang
Copy link
Collaborator

Work tracked here: https://jira.cms.gov/browse/WNMGDS-657

@bernardwang
Copy link
Collaborator

@kathleenmeditz and I are in the middle of some Step List exploration work so hopefully after that we can have a clearer picture if deprecating at the core design system level makes sense. 👍

As I understand, that StepList exploration is mostly around enhancing it or exploring other progress related components right? Can that be separate from the question of where we include a StepList component?

@line47
Copy link
Contributor

line47 commented Oct 12, 2020

The only thing I'm not sure clear on yet is if teams from Medicare Design System are using the Step List

@bernardwang
Copy link
Collaborator

I'm pretty sure MCT isnt, and I think other Mgov teams shouldnt be too hard to confirm. However I am wondering if there are other non HC.gov teams that are using it. We should also thoroughly plan out a deprecation/communication process, but both of these things I'm thinking can be separate from the design work.

@bernardwang bernardwang added the Status: In JIRA Indicates that this item is also tracked in Jira label Oct 12, 2020
@bernardwang
Copy link
Collaborator

A fix will be included in the next HCgov DS release after this PR is reviewed and merged. It will also be fixed in the next core release after this PR is merged and released.

@bernardwang
Copy link
Collaborator

Fixed in v2.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In JIRA Indicates that this item is also tracked in Jira Type: Fixed Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants