Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "unable to save" warning to use modal pattern #2406

Closed
3 tasks done
jeromeleecms opened this issue Aug 3, 2020 · 3 comments · Fixed by #2848
Closed
3 tasks done

Update "unable to save" warning to use modal pattern #2406

jeromeleecms opened this issue Aug 3, 2020 · 3 comments · Fixed by #2848
Assignees
Labels
bug needs triage, then squashing Development Issues for the dev team resolve front-end medium sev3 Experience is flawed but not unusable.

Comments

@jeromeleecms
Copy link
Contributor

jeromeleecms commented Aug 3, 2020

Update the "unexpected error saving" message to use the modal pattern provided by design.cms.gov

Update the text on the save changes error pop-up

Header: Unable to save changes!

Body: Your changes aren't being saved. Try saving your changes again in a few minutes by clicking on the save button. If you refresh your browser without saving backing up your changes, changes made after this message appeared will be lost.

This task is done when...

  • Old message pattern is removed
  • "Unexpected error saving" now uses the modal pattern
  • Update the text in the modal to the above header/body text
@jeromeleecms jeromeleecms added bug needs triage, then squashing sev3 Experience is flawed but not unusable. labels Aug 3, 2020
@nicholeweems nicholeweems added the Development Issues for the dev team resolve label Aug 4, 2020
@tbolt tbolt self-assigned this Feb 2, 2021
@nicholeweems nicholeweems added this to the 01/25/2021 - 02/05/2021 milestone Feb 2, 2021
@tbolt tbolt changed the title When the screen is too narrow, the Warning Dialogue Box Appears Update "unable to save" warning to use modal pattern Feb 2, 2021
@tbolt tbolt added medium and removed small labels Feb 3, 2021
@beparticular
Copy link

beparticular commented Feb 3, 2021

Here is the language from the closed design ticket to use on this modal. I'm not sure what the corresponding dev ticket is and didn't find a duplicate. [Update: here is the duplicate #2803.]

Header: Unable to save changes!

Body: Your changes aren't being saved. Try saving your changes again in a few minutes by clicking on the save button. If you refresh your browser without saving or backing up your changes, changes made after this message appeared will be lost.

@eStar386
Copy link
Contributor

QA Passed: Verified that the modal appeared when applicable at the top of the header/body text.

@eStar386
Copy link
Contributor

Please use the test script when testing in addition to any personal methods https://drive.google.com/file/d/1cazcjKnuzwWaipu5iHaooZDsbYJG9wJr/view?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage, then squashing Development Issues for the dev team resolve front-end medium sev3 Experience is flawed but not unusable.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants