Email State Admin from State Dashboard when Affiliation is Pending #2838

radavis · 2021-02-03T17:36:02Z

Resolves #2771

This pull request is ready to merge when...

Tests have been updated (and all tests are passing)
This code has been reviewed by someone other than the original author
The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented
The change has been documented
- Associated OpenAPI documentation has been updated
Changelog is updated as appropriate

This feature is done when...

QA has approved the experience
Design has approved the experience
Product has approved the experience

Steps to verify this PR:

Create an Okta User: https://test.reg.idm.cms.gov/registration.html?appid=eapd
Login
Select 'Alaska'
Verify that 'State Administrator' link is present with href='mailto:...'
Login into the em@il user account and verify the new user(s) requested for Alaska is in pending deliveries.

Repeat steps above with another user, a different state (e.g. - 'Alabama') and verify 'State Administrator' is present with 'href=mailto:CMS-EAPD@cms.hhs.gov' (no state admin assigned, yet).

cms-eapd-bot · 2021-02-03T17:55:49Z

This deploy was cleaned up.

codecov-io · 2021-02-09T20:49:09Z

Codecov Report

Merging #2838 (f517121) into master (eb928de) will decrease coverage by 0.55%.
The diff coverage is 69.87%.

❗ Current head f517121 differs from pull request most recent head d83c857. Consider uploading reports for the commit d83c857 to get more accurate results

@@            Coverage Diff             @@
##           master    #2838      +/-   ##
==========================================
- Coverage   89.03%   88.48%   -0.56%     
==========================================
  Files         273      274       +1     
  Lines        5007     5019      +12     
  Branches      965      972       +7     
==========================================
- Hits         4458     4441      -17     
- Misses        506      535      +29     
  Partials       43       43

Impacted Files	Coverage Δ
api/routes/states/get.js	`50.00% <33.33%> (ø)`
api/db/states.js	`81.81% <50.00%> (-7.08%)`	⬇️
api/db/oktaUsers.js	`66.66% <66.66%> (ø)`
web/src/components/StateAffiliationStatus.js	`70.00% <70.00%> (ø)`
web/src/components/ApdList.js	`74.28% <74.28%> (ø)`
api/db/users.js	`58.69% <100.00%> (+1.87%)`	⬆️
web/src/containers/StateDashboard.js	`76.92% <100.00%> (-7.99%)`	⬇️
web/src/lazy/zxcvbn.js	`20.00% <0.00%> (-80.00%)`	⬇️
web/src/containers/Login.js	`70.58% <0.00%> (-29.42%)`	⬇️
web/src/actions/auth.js	`80.00% <0.00%> (-16.50%)`	⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb928de...d83c857. Read the comment docs.

radavis · 2021-03-02T17:04:43Z

@eStar386 I was able to confirm this issue.

Requests from the front-end when viewing the /state-admin path were returning 502 Bad Gateway responses. Thus, no information was being retrieved from the back-end.

Merging changes from master seem to have corrected this problem. Please re-test when you have the time. Thank you.

eStar386 · 2021-03-10T13:36:45Z

Retested and this resolves the bug.

jeromeleecms

The scope of the PR does not reflect the scope of the actual issue. We should also have this same functionality for the "Denied Dashboard" as well:

Currently the text does not link to anything. If we do change the scope of this issue, let's change the title to include all dashboards -- or I'm OK with switching it to a separate issue to resolve. @thetif

…2771 � Conflicts: � bin/preview-deploy/aws.user-data.sh � web/package-lock.json � web/src/containers/StateDashboard.test.js

thetif · 2021-03-23T21:52:21Z

bin/preview-deploy/aws.sh

@@ -116,7 +116,7 @@ function createNewInstance() {
    --subnet-id "$AWS_SUBNET" \
    --tag-specification "ResourceType=instance,Tags=[{Key=Name,Value=eAPD PR $PR_NUM},{Key=environment,Value=preview},{Key=github-pr,Value=${PR_NUM}}]" \
    --user-data file://aws.user-data.sh \
-    --key-name eapd_bbrooks \
+    --key-name radavis \
    | jq -r -c '.Instances[0].InstanceId'


@knollfear can you remove this key?

sure. I have no idea why this is part of the MR, I didn't look at this part.

tbolt

Nice work

NAretakis

I see the admin email, clicking it works too!! Good to go!

…2771 � Conflicts: � CHANGELOG.md � web/src/containers/StateDashboard.js � web/src/containers/StateDashboard.test.js

…2771 � Conflicts: � web/src/containers/StateDashboard.js � web/src/containers/StateDashboard.test.js

eStar386

Passed - the denied and revoked panels are added. Testing information above.

radavis added 2 commits February 3, 2021 12:31

persist okta user data

66c1c6d

await

e78fdce

radavis added 13 commits February 3, 2021 14:18

add ssh key

8c6ffcf

fix insert statement

954e16a

persist email

392b37a

Merge branch 'master' into radavis/2771

8ebecfe

store okta user_id and email

ed4cd77

Merge branch 'master' into radavis/2771

c8d47ec

create or update okta_users

7463ac2

add getStateAdmins

f537ac6

Merge branch 'master' into radavis/2771

44543cd

save point

8c48fff

add mailto link to StateDashboard

adb98c2

update test

423a8a6

update tests

75b6f48

radavis added 3 commits February 10, 2021 12:03

fetch state information

8a9bf34

add space

52dacc8

update endpoint test

f70aaae

radavis changed the title ~~persist okta user data~~ Email State Admin from State Dashboard when Affiliation is Pending Feb 10, 2021

radavis added 4 commits February 10, 2021 13:48

props dance

c0295fd

save point

202d378

Refactor StateDashboard Component

03ca90a

merge radavis/refactor-state-dashboard

be19d0f

radavis mentioned this pull request Feb 12, 2021

Refactor StateDashboard Component #2870

Closed

9 tasks

radavis added 3 commits February 12, 2021 11:38

save point

d5d533d

save point

60351ff

lint

d8e6309

radavis marked this pull request as ready for review February 12, 2021 17:03

radavis added 3 commits March 1, 2021 15:47

add key

eeacfed

add debug flag

b254c4e

merge master

7a787f7

eStar386 approved these changes Mar 10, 2021

View reviewed changes

jeromeleecms reviewed Mar 10, 2021

View reviewed changes

knollfear added 4 commits March 18, 2021 15:01

Merge branch 'master' of https://github.com/CMSgov/eAPD into radavis/…

0dd9a97

…2771 � Conflicts: � bin/preview-deploy/aws.user-data.sh � web/package-lock.json � web/src/containers/StateDashboard.test.js

reduced to a single component and beefed up the unit testing a bit.

61b6013

adding component to story book

5d086b6

removing unneeded imports.

64a0f47

knollfear requested review from thetif and tbolt March 23, 2021 18:04

knollfear assigned thetif and tbolt Mar 23, 2021

thetif requested changes Mar 24, 2021

View reviewed changes

tbolt approved these changes Mar 25, 2021

View reviewed changes

removing key from createNewInstance

e2b74fd

thetif approved these changes Mar 25, 2021

View reviewed changes

thetif requested a review from NAretakis March 30, 2021 18:09

NAretakis approved these changes Mar 30, 2021

View reviewed changes

knollfear and others added 6 commits March 30, 2021 15:07

Merge branch 'master' of https://github.com/CMSgov/eAPD into radavis/…

e0447f0

…2771 � Conflicts: � CHANGELOG.md � web/src/containers/StateDashboard.js � web/src/containers/StateDashboard.test.js

fixing merge conflict for isFedAdmin check.

7ed8a4e

Merge branch 'master' into radavis/2771

e740071

missing space between state and "APD's"

fefcd3c

Merge remote-tracking branch 'origin/radavis/2771' into radavis/2771

f517121

Merge branch 'master' of https://github.com/CMSgov/eAPD into radavis/…

d83c857

…2771 � Conflicts: � web/src/containers/StateDashboard.js � web/src/containers/StateDashboard.test.js

eStar386 approved these changes Apr 1, 2021

View reviewed changes

knollfear merged commit d59e1c7 into master Apr 5, 2021

knollfear deleted the radavis/2771 branch April 5, 2021 13:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Email State Admin from State Dashboard when Affiliation is Pending #2838

Email State Admin from State Dashboard when Affiliation is Pending #2838

radavis commented Feb 3, 2021 •

edited by eStar386

cms-eapd-bot commented Feb 3, 2021 •

edited

codecov-io commented Feb 9, 2021 •

edited

radavis commented Mar 2, 2021

eStar386 commented Mar 10, 2021

jeromeleecms left a comment

thetif Mar 23, 2021

knollfear Mar 24, 2021

tbolt left a comment

NAretakis left a comment

eStar386 left a comment

Email State Admin from State Dashboard when Affiliation is Pending #2838

Email State Admin from State Dashboard when Affiliation is Pending #2838

Conversation

radavis commented Feb 3, 2021 • edited by eStar386

This pull request is ready to merge when...

This feature is done when...

Steps to verify this PR:

cms-eapd-bot commented Feb 3, 2021 • edited

codecov-io commented Feb 9, 2021 • edited

Codecov Report

radavis commented Mar 2, 2021

eStar386 commented Mar 10, 2021

jeromeleecms left a comment

Choose a reason for hiding this comment

thetif Mar 23, 2021

Choose a reason for hiding this comment

knollfear Mar 24, 2021

Choose a reason for hiding this comment

tbolt left a comment

Choose a reason for hiding this comment

NAretakis left a comment

Choose a reason for hiding this comment

eStar386 left a comment

Choose a reason for hiding this comment

radavis commented Feb 3, 2021 •

edited by eStar386

cms-eapd-bot commented Feb 3, 2021 •

edited

codecov-io commented Feb 9, 2021 •

edited