-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added title case to various heading, titles, etc... #3359
Conversation
Codecov Report
@@ Coverage Diff @@
## development #3359 +/- ##
===============================================
- Coverage 88.68% 88.65% -0.04%
===============================================
Files 282 282
Lines 5578 5580 +2
Branches 1067 1069 +2
===============================================
Hits 4947 4947
- Misses 578 580 +2
Partials 53 53
Continue to review full report at Codecov.
|
|
||
const thId = (program, share) => | ||
`program-budget-table-${program}${share ? `-${share}` : ''}`; | ||
titleCase(`program-budget-table-${program}${share ? `-${share}` : ''}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, sorry, we don't need it here or in the next line, didn't realize that those are just ids
…m/CMSgov/eAPD into dmirano/2438-title-case-component
…m:CMSgov/eAPD into dmirano/2438-title-case-component
…8-title-case-component
This deploy was cleaned up. |
c3dd5e8
to
3f56d83
Compare
3f56d83
to
7da9afa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sorry @mirano-darren I pulled this down to look at the package-lock file and then ended up pulling Bill's branch in here by mistake and then I couldn't roll it back 🤦. I got it back to how you had it but I lost your git commit history. You still get full credit for this one though! |
All good! :D |
@mirano-darren @thetif I can see where most of these have been updated. Some I'm not sure, they appear to be title case already in staging. One thing I did want to check on, in Assurances and Compliances a couple of the links appear to be missing in this test environment. Can you take a look and see if that's related to something else, or if something happened there? Thanks! |
…m/CMSgov/eAPD into dmirano/2438-title-case-component
@mirano-darren @thetif There are still some items in the executive summary that look like they should be title case. Those look like they could be the same style as the summaries on Private Contractor Cost or Outcomes and Metrics? |
…m/CMSgov/eAPD into dmirano/2438-title-case-component
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through each page. No crashes - title case seems to be working as implemented.
resolves #2438
Description-
Added title case to various titles, labels, headings, etc...
This pull request changes...
This pull request also touches…
possible side effects of this change
This pull request was tested in the follow ways…
Steps to manually verify this change...
This pull request is ready to review when...
This pull request can be merged when…