Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added title case to various heading, titles, etc... #3359

Merged
merged 43 commits into from
Sep 13, 2021

Conversation

mirano-darren
Copy link
Contributor

resolves #2438

Description-
Added title case to various titles, labels, headings, etc...

This pull request changes...

  • web/src/components/Instructions.js
  • web/src/components/Section.js
  • web/src/containers/ApdStateProfileMedicaidOffice.js
  • web/src/containers/AssurancesAndCompliances.js
  • web/src/containers/ExecutiveSummaryBudget.js
  • web/src/containers/PreviousActivities
  • web/src/containers/activity/CostAllocateFFP.js
  • web/src/containers/activity/CostAllocateFFPQuarterly.js
  • web/src/containers/activity/Costs.js
  • web/src/containers/activity/EntryDetails.js
  • web/src/containers/activity/CostAllocation/OtherFunding.js
  • web/src/containers/ApdKeyPerson/ApdKeyPersonForm.js
  • web/src/containers/viewOnly/AssurancesAndCompliances.js
  • web/src/containers/viewOnly/ExecutiveSummary.js
  • web/src/reducers/nav.items.js
  • web/src/components/ContinuePreviewButtons.js

This pull request also touches…

  • web/package.json
  • web/package-lock.json

possible side effects of this change

  • Could crash the website if titleCase() was called wrong, but I made sure this wasn't the case before creating this PR

This pull request was tested in the follow ways…

  • Going to each page on the website and making sure it doesn't crash

Steps to manually verify this change...

  1. See if everything desired is title cased correctly

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2021

Codecov Report

Merging #3359 (9b2f4dd) into development (8ce0212) will decrease coverage by 0.03%.
The diff coverage is 45.45%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3359      +/-   ##
===============================================
- Coverage        88.68%   88.65%   -0.04%     
===============================================
  Files              282      282              
  Lines             5578     5580       +2     
  Branches          1067     1069       +2     
===============================================
  Hits              4947     4947              
- Misses             578      580       +2     
  Partials            53       53              
Impacted Files Coverage Δ
api/seeds/development/apds.js 55.55% <ø> (ø)
web/src/components/Instruction.js 96.77% <ø> (ø)
...eb/src/containers/ApdStateProfileMedicaidOffice.js 100.00% <ø> (ø)
web/src/containers/AssurancesAndCompliance.js 90.00% <ø> (ø)
web/src/containers/ExecutiveSummary.js 100.00% <ø> (ø)
web/src/containers/ExecutiveSummaryBudget.js 100.00% <ø> (ø)
web/src/containers/PreviousActivities.js 100.00% <ø> (ø)
web/src/containers/activity/CostAllocateFFP.js 100.00% <ø> (ø)
...rc/containers/activity/CostAllocateFFPQuarterly.js 100.00% <ø> (ø)
...containers/activity/CostAllocation/OtherFunding.js 60.00% <ø> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce0212...9b2f4dd. Read the comment docs.

web/src/components/Instruction.js Outdated Show resolved Hide resolved
web/src/components/Section.js Outdated Show resolved Hide resolved

const thId = (program, share) =>
`program-budget-table-${program}${share ? `-${share}` : ''}`;
titleCase(`program-budget-table-${program}${share ? `-${share}` : ''}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, sorry, we don't need it here or in the next line, didn't realize that those are just ids

@cms-eapd-bot
Copy link

cms-eapd-bot commented Aug 5, 2021

This deploy was cleaned up.

@thetif thetif force-pushed the dmirano/2438-title-case-component branch from c3dd5e8 to 3f56d83 Compare August 5, 2021 18:08
@thetif thetif force-pushed the dmirano/2438-title-case-component branch from 3f56d83 to 7da9afa Compare August 5, 2021 18:18
Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thetif
Copy link
Contributor

thetif commented Aug 5, 2021

Sorry @mirano-darren I pulled this down to look at the package-lock file and then ended up pulling Bill's branch in here by mistake and then I couldn't roll it back 🤦. I got it back to how you had it but I lost your git commit history. You still get full credit for this one though!

@mirano-darren
Copy link
Contributor Author

Sorry @mirano-darren I pulled this down to look at the package-lock file and then ended up pulling Bill's branch in here by mistake and then I couldn't roll it back 🤦. I got it back to how you had it but I lost your git commit history. You still get full credit for this one though!

All good! :D

@beparticular
Copy link

@mirano-darren @thetif I can see where most of these have been updated. Some I'm not sure, they appear to be title case already in staging.

One thing I did want to check on, in Assurances and Compliances a couple of the links appear to be missing in this test environment. Can you take a look and see if that's related to something else, or if something happened there? Thanks!

@beparticular
Copy link

@mirano-darren @thetif
This is looking good, I can see where most of the changes are.

There are still some items in the executive summary that look like they should be title case.
Total cost:
Start date - End date: Date not specified - Date not specified
Total cost of activity:
Total funding request:

Those look like they could be the same style as the summaries on Private Contractor Cost or Outcomes and Metrics?

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through each page. No crashes - title case seems to be working as implemented.

@tbolt tbolt merged commit d18401e into development Sep 13, 2021
@tbolt tbolt deleted the dmirano/2438-title-case-component branch September 13, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Title Case component and use for all Nav Items, Section Titles, and Table Headers
8 participants