-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tbolt/3257 state admin cert endpoint #3450
Conversation
… state admin certifications table
…tion file, remove previous work
…es; add or remove
…te-admin-cert-endpoint
…te-admin-cert-endpoint
Codecov Report
@@ Coverage Diff @@
## development #3450 +/- ##
===============================================
+ Coverage 88.57% 88.60% +0.03%
===============================================
Files 282 284 +2
Lines 5591 5615 +24
Branches 1073 1073
===============================================
+ Hits 4952 4975 +23
- Misses 586 587 +1
Partials 53 53
Continue to review full report at Codecov.
|
This deploy was cleaned up. |
…gov/eAPD into tbolt/3257-state-admin-cert-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
uploadedOn: new Date() | ||
}); | ||
if (error) { | ||
res.status(400).end(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this not trigger next to kick it over to the error handler?
Resolves #3257
Description-
Adds endpoint
/auth/certifications
to allow a Fed Admin to submit a state admin certification letterThis pull request was tested in the follow ways…
Steps to manually verify this change...
auth/certifications
with no valid jwt, verify a401
is thrown403
200
400
as the email + state must be uniqueSample JSON Body
This pull request is ready to review when...
This pull request can be merged when…