Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update design.md #3457

Merged
merged 6 commits into from
Sep 9, 2021
Merged

Conversation

jeromeleecms
Copy link
Contributor

resolves #

Description-

This pull request changes...

  • expected change 1
  • expected change 2

This pull request also touches…

  • possible side effects of this change

This pull request was tested in the follow ways…

  • list of frontend cases
  • list of backend cases

Steps to manually verify this change...

  1. steps to view and verify change

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@codecov-commenter
Copy link

Codecov Report

Merging #3457 (b7fb621) into development (c2e3da2) will decrease coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3457      +/-   ##
===============================================
- Coverage        88.84%   88.68%   -0.17%     
===============================================
  Files              282      282              
  Lines             5578     5578              
  Branches          1067     1067              
===============================================
- Hits              4956     4947       -9     
- Misses             569      578       +9     
  Partials            53       53              
Impacted Files Coverage Δ
api/files/local.js 19.04% <0.00%> (-42.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e3da2...b7fb621. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Sep 9, 2021

This deploy was cleaned up.

@jeromeleecms jeromeleecms merged commit 01cb487 into development Sep 9, 2021
@jeromeleecms jeromeleecms deleted the jeromeleecms-updated-designtemplate branch September 9, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants