-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Activity quarter table bug across multiple activities [#3459] #3459
Conversation
This deploy was cleaned up. |
Codecov Report
@@ Coverage Diff @@
## development #3459 +/- ##
===============================================
- Coverage 88.60% 88.53% -0.07%
===============================================
Files 284 284
Lines 5615 5616 +1
Branches 1073 1073
===============================================
- Hits 4975 4972 -3
- Misses 587 591 +4
Partials 53 53
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me. Followed repro instructions and it behaved as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Check budget math on export and total amounts - looks like it matches. Subtotals reflect the calculated amount from the app vs. what is the subtotal calculated from what the data entry is (i.e. you can have something less than 100% represented in the quarterly table and the subtotal will still line up with 100% of the cost of the activity). If I recall that was by design.
Also verified number formatting and that works as advertised.
resolves #3419
Description-
If you navigated between Activity's Budget and FFP pages the quarterly percentages were always showing the first one you had opened. If you went to a different page between the Budget and FFP pages it would show the correct value. I thought this might be related to #2822. We weren't able to have the useEffect because we didn't have the ability to mask the value properly so it was losing formatting. CMS Design system recently exported the maskValue function they use, so I was able to import it into NumberField and bring back the useEffect.
This pull request changes...
This pull request also touches…
Steps to manually verify this change...
This pull request is ready to review when...
This pull request can be merged when…