Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for checking the Activity Schedule Summary for a filled out APD #3468

Merged
merged 14 commits into from
Sep 21, 2021

Conversation

thetif
Copy link
Contributor

@thetif thetif commented Sep 10, 2021

resolves #3436

Description-
Adds tests for a filled out Activity Schedule Summary

This pull request changes...

  • adds tests for Activity Schedule Summary once the activities have been filled out

This pull request also touches…

  • updated some of the page-object names so they would be more interchangeable between the form view and export view

Steps to manually verify this change...

  1. pull down PR
  2. run npm run cy:run in the integrationTests folder

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@cms-eapd-bot
Copy link

cms-eapd-bot commented Sep 10, 2021

This deploy was cleaned up.

Copy link
Contributor

@chris-miraflor chris-miraflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test works for me.

@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2021

Codecov Report

Merging #3468 (35f5957) into development (26b43dd) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3468      +/-   ##
===============================================
+ Coverage        88.53%   88.60%   +0.07%     
===============================================
  Files              284      284              
  Lines             5616     5616              
  Branches          1073     1073              
===============================================
+ Hits              4972     4976       +4     
+ Misses             591      587       -4     
  Partials            53       53              
Impacted Files Coverage Δ
api/files/local.js 38.09% <0.00%> (+19.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26b43dd...35f5957. Read the comment docs.

@thetif thetif merged commit a575163 into development Sep 21, 2021
@thetif thetif deleted the tforkner/3436-activity-schedule-summary branch September 21, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add e2e test for checking the Activity Schedule Summary for a filled out APD
5 participants