Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing some small issues with the cypress tests due to code changes. #3476

Merged
merged 2 commits into from
Sep 17, 2021

Conversation

knollfear
Copy link
Contributor

Resolves #

Description-

This fixes some small things that have changed causing the cypress tests to fail.

This pull request changes...

how some elements are located in the cypres tests

This pull request also touches…

  • possible side effects of this change
    none, it is just test code.

This pull request was tested in the follow ways…

  • cypress tests should succeed

Steps to manually verify this change...

  1. Run the cypress tests

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

Copy link
Contributor

@cthulhuplus cthulhuplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it will address the failures that I'm seeing in my CI Cypress PR.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Sep 17, 2021

This deploy was cleaned up.

@codecov-commenter
Copy link

codecov-commenter commented Sep 17, 2021

Codecov Report

Merging #3476 (d43d4b4) into development (6e6293f) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #3476      +/-   ##
===============================================
+ Coverage        88.53%   88.69%   +0.16%     
===============================================
  Files              284      284              
  Lines             5615     5615              
  Branches          1073     1073              
===============================================
+ Hits              4971     4980       +9     
+ Misses             591      582       -9     
  Partials            53       53              
Impacted Files Coverage Δ
api/files/local.js 61.90% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e6293f...d43d4b4. Read the comment docs.

@knollfear knollfear merged commit 611382c into development Sep 17, 2021
@knollfear knollfear deleted the knollfear/cypress-fixes branch September 17, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants