Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tbolt/3416 Fed Admin - State Admin Letters Tab #3504

Merged
merged 110 commits into from
Oct 21, 2021
Merged

Conversation

tbolt
Copy link
Contributor

@tbolt tbolt commented Sep 29, 2021

Resolves #3416

Description-

  • Adds State Admin Letters to the fed admin dashboard

Steps to manually verify this change...

  1. Login as fed admin
  2. Verify the new State Admin Letters table is working as expected
  3. Test filters work (and they work in conjunction with each other)
  4. Test global search works

Developer Notes

  • Instead of having a search for only email and name, its a global search. So you can search by name + email but also state, status, etc
  • The icons for the sort indicators are currently unicode characters. If they are not sufficient, I can switch them to actual icons
  • I removed the actions until we implement them in subsequent stories
  • The view document/file works by simply downloading the original file. I was unable to find a way to have it open in a tab. I believe we may need to change how we are serving it up on the backend. Additionally we have another story to update how we are handling files so we could handle it in that story if that is still preferred

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2021

Codecov Report

Merging #3504 (86b7d56) into main (07e447a) will decrease coverage by 0.52%.
The diff coverage is 46.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3504      +/-   ##
==========================================
- Coverage   88.72%   88.20%   -0.53%     
==========================================
  Files         301      302       +1     
  Lines        5784     5866      +82     
  Branches     1088     1099      +11     
==========================================
+ Hits         5132     5174      +42     
- Misses        597      629      +32     
- Partials       55       63       +8     
Impacted Files Coverage Δ
web/src/containers/FederalDashboard.js 87.50% <ø> (ø)
web/src/containers/admin/DelegateStateAdminForm.js 14.28% <0.00%> (+3.64%) ⬆️
web/src/components/DocumentUpload.js 10.00% <10.00%> (ø)
web/src/containers/admin/StateAdminLetters.js 55.69% <53.33%> (-24.31%) ⬇️
api/routes/auth/certifications/files/get.js 94.11% <100.00%> (ø)
api/routes/auth/certifications/files/post.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07e447a...86b7d56. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Oct 19, 2021

This deploy was cleaned up.

@tbolt tbolt temporarily deployed to Preview October 20, 2021 12:58 Inactive
</TableBody>
</Table>

<div className="ds-u-display--flex ds-u-justify-content--end ds-u-padding-y--2">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you might want to pull this out into it's own component too

web/audit-ci.json Outdated Show resolved Hide resolved
@cthulhuplus cthulhuplus changed the base branch from development to main October 20, 2021 16:17
@tbolt tbolt temporarily deployed to Preview October 21, 2021 14:18 Inactive
Copy link

@beparticular beparticular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to be working as expected here!

Copy link
Contributor

@jeromeleecms jeromeleecms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as advertised. Also tested basic keyboard navigation.

@tbolt tbolt merged commit 47eb597 into main Oct 21, 2021
@tbolt tbolt deleted the tbolt/3416-fed-admin branch October 21, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] State Admin Letters tab - Frontend
7 participants