Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bbrooks/CircleCi_Node_Issue #3522

Merged
merged 36 commits into from
Oct 5, 2021
Merged

Conversation

cthulhuplus
Copy link
Contributor

@cthulhuplus cthulhuplus commented Oct 4, 2021

Resolves # CircleCI build issues with OWASP Zap Scan, Backend API Endpoint Test, and Backend Unit Test

Description-
CircleCI build were failing OWASP Zap Scan, Backend API Endpoint Test, and Backend Unit Test.

This pull request changes...

  • Machine Images that CircleCI uses for OWASP Zap Scan, Backend API Endpoint Test, and Backend Unit Test.

This pull request also touches…
Node version (image contains newer? versions of software)

  • possible side effects of this change

This pull request was tested in the follow ways…

  • list of frontend cases
  • list of backend cases

Steps to manually verify this change...

  1. steps to view and verify change

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #3522 (e37d138) into development (9ce7e55) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #3522   +/-   ##
============================================
  Coverage        88.79%   88.79%           
============================================
  Files              284      284           
  Lines             5616     5616           
  Branches          1073     1073           
============================================
  Hits              4987     4987           
  Misses             576      576           
  Partials            53       53           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce7e55...e37d138. Read the comment docs.

@cms-eapd-bot
Copy link

cms-eapd-bot commented Oct 4, 2021

This deploy was cleaned up.

@cthulhuplus cthulhuplus changed the title Debugging node var for OWASP bbrooks/CircleCi_Node_Issue Oct 5, 2021
@cthulhuplus cthulhuplus merged commit 84d2774 into development Oct 5, 2021
@cthulhuplus cthulhuplus deleted the bbrooks/CircleCi_Node_Issue branch October 5, 2021 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants