Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tbolt/Storybook Deploy fix #3870

Merged
merged 11 commits into from Mar 15, 2022
Merged

Tbolt/Storybook Deploy fix #3870

merged 11 commits into from Mar 15, 2022

Conversation

tbolt
Copy link
Contributor

@tbolt tbolt commented Mar 15, 2022

Resolves #

Description-

This pull request changes...

  • expected change 1
  • expected change 2

This pull request also touches…

  • possible side effects of this change

This pull request was tested in the follow ways…

  • list of frontend cases
  • list of backend cases

Steps to manually verify this change...

  1. steps to view and verify change

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@tbolt tbolt temporarily deployed to Preview March 15, 2022 13:22 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Mar 15, 2022

Codecov Report

Merging #3870 (e5bc91b) into main (7e76adb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3870   +/-   ##
=======================================
  Coverage   83.34%   83.34%           
=======================================
  Files         313      313           
  Lines        6393     6393           
  Branches     1203     1203           
=======================================
  Hits         5328     5328           
  Misses        971      971           
  Partials       94       94           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e76adb...e5bc91b. Read the comment docs.

@tbolt tbolt requested a review from thetif March 15, 2022 13:49
@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 15, 2022

This deploy was cleaned up.

@thetif
Copy link
Contributor

thetif commented Mar 15, 2022

@tbolt I don't think we need @jeromeleecms to review this since it's just a CI fix. You can go ahead and merge it.

@tbolt tbolt merged commit 59cc488 into main Mar 15, 2022
@tbolt tbolt deleted the tbolt/storybook-deploy-fix branch March 15, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants