Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dmirano/3775 dashboard restructure #3881

Merged
merged 9 commits into from Mar 22, 2022
Merged

Dmirano/3775 dashboard restructure #3881

merged 9 commits into from Mar 22, 2022

Conversation

mirano-darren
Copy link
Contributor

Resolves #3775

Description-
adds dashboard component refactor

This pull request changes...

  • relocates dashboard components

This pull request was tested in the follow ways…

  • npm test in /web/ pass
  • app boots up normally

Steps to manually verify this change...

  1. frontend files are where they need to be

This pull request is ready to review when...

  • Automated tests are updated (and all tests are passing)
  • The change has been documented
  • Associated OpenAPI documentation has been updated
  • Changelog is updated as appropriate
  • The experience passes a basic manual accessibility audit (keyboard nav, screenreader, text scaling) OR an exemption is documented

This pull request can be merged when…

  • Code has been reviewed by someone other than the original author
  • QA has verified the accessibility and functionality related to the change
  • Design has approved the experience
  • Product has approved the experience

@mirano-darren mirano-darren temporarily deployed to Preview March 22, 2022 15:49 Inactive
@mirano-darren mirano-darren temporarily deployed to Preview March 22, 2022 17:36 Inactive
@thetif thetif temporarily deployed to Preview March 22, 2022 18:01 Inactive
@thetif thetif temporarily deployed to Preview March 22, 2022 20:22 Inactive
@cms-eapd-bot
Copy link

cms-eapd-bot commented Mar 22, 2022 •
edited

This deploy was cleaned up.

thetif
thetif approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@thetif thetif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@thetif thetif temporarily deployed to Preview March 22, 2022 21:25 Inactive
@mirano-darren mirano-darren merged commit 886da39 into main Mar 22, 2022
@mirano-darren mirano-darren deleted the dmirano/3775-dashboard-restructure branch March 22, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetif thetif thetif approved these changes

@tbolt tbolt Awaiting requested review from tbolt

@Sun-Mountain Sun-Mountain Awaiting requested review from Sun-Mountain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] move dashboard components into a dashboard folder
3 participants
@mirano-darren @cms-eapd-bot @thetif